From test-dev-return-2323-apmail-httpd-test-dev-archive=httpd.apache.org@httpd.apache.org Thu Jan 15 19:09:25 2004 Return-Path: Delivered-To: apmail-httpd-test-dev-archive@www.apache.org Received: (qmail 10610 invoked from network); 15 Jan 2004 19:09:25 -0000 Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12) by minotaur-2.apache.org with SMTP; 15 Jan 2004 19:09:25 -0000 Received: (qmail 32129 invoked by uid 500); 15 Jan 2004 19:09:16 -0000 Delivered-To: apmail-httpd-test-dev-archive@httpd.apache.org Received: (qmail 32018 invoked by uid 500); 15 Jan 2004 19:09:16 -0000 Mailing-List: contact test-dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: test-dev@httpd.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list test-dev@httpd.apache.org Received: (qmail 32003 invoked from network); 15 Jan 2004 19:09:15 -0000 Received: from unknown (HELO mail.logilune.com) (195.154.174.52) by daedalus.apache.org with SMTP; 15 Jan 2004 19:09:15 -0000 Received: from stason.org (localhost.logilune.com [127.0.0.1]) by mail.logilune.com (Postfix) with ESMTP id 8B87278D92 for ; Thu, 15 Jan 2004 20:09:18 +0100 (CET) Message-ID: <4006E55D.5070800@stason.org> Date: Thu, 15 Jan 2004 11:09:17 -0800 From: Stas Bekman Organization: Hope, Humanized User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5) Gecko/20031010 X-Accept-Language: en-us, en, he, ru MIME-Version: 1.0 To: test-dev@httpd.apache.org Subject: Re: [Fwd: Re: Modperl 2.0 Not finding correct *.conf] References: <4005CFA7.3000307@stason.org> <4006BC44.8060600@modperlcookbook.org> In-Reply-To: <4006BC44.8060600@modperlcookbook.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Geoffrey Young wrote: > > Stas Bekman wrote: > >>any objections for this patch? > > >>- if (-e $result) { >>- debug "$file successfully resolved to existing file $result"; > > > well, you're removing the file check in favor of a directory check. in the > interests of debugging, I'd probably like to preserve the check and throw a > warning when $dir exists but the resolved file does not. I think the caller > is responsible for making sure the file exists because it may or may not > care and result of the call is the same no matter what. but it was nice to > have the debug output the last time I worked on this chunk of code. yes, but we don't want users to complain about: *** file /etc/httpd/conf.d/*.conf does not exist and several people did already. Obviously /etc/httpd/conf.d/*.conf doesn't exist, so what good does this test make? The caller already checks whether the output of glob() exists before using it. So I thought that the purpose of this function is the same as rel2abs (Which does not check whether the resulting file or whatever exists) the only difference is that it uses extra heuristics to get the value of the base. Therefore I think checking for the directory is the right thing to do. In any case, adding a check for a file is fine with me as long as you s/warning/debug/, so it won't appear in the normal output and users don't send false complaints. How about adding it as an extra check on top of this patch? __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:stas@stason.org http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com