httpd-test-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject Re: sticky preferences in Apache-Test
Date Thu, 08 Jan 2004 21:21:35 GMT
Geoffrey Young wrote:
>>Can you please run t/TEST -debug=trace and see which TestConfigData.pm
>>is loaded? what's inside of it? May be the simple solution is not to
>>load custom_config when running from inside modperl-2.0? I think that's
>>the best solution.
> 
> 
> I've already cleaned everything out for today, but I'll do that tomorrow
> after my nightly builds run.

Try with the patch below. I haven't tested it, without having your debug input.

>>The problem is that we have 4 TestConfigData.pm files. If you are inside
>>modperl-2.0 or Apache-Test, you have one in lib and one in blib, the one
>>in lib is created as an empty config during 'perl Makefile.PL' then it's
>>copied to blib. Things gets complicated when you have a global 
>>TestConfigData.pm installed and when you have ~/.apache-test one
>>installed. It gets very tricky.
> 
> 
> no doubt :)
> 
> it is possible to have a makepl_args.mod_perl2 setting whereby using saved
> settings is skipped altogether?  with all the builds that we both do
> nightly, that's the way I'd prefer to do at least infers from the build
> enviroment at the moment.

I think the patch below handles that fine for any mp2 builds.

Index: lib/Apache/TestRun.pm
===================================================================
RCS file: /home/cvs/httpd-test/perl-framework/Apache-Test/lib/Apache/TestRun.pm,v
retrieving revision 1.135
diff -u -r1.135 TestRun.pm
--- lib/Apache/TestRun.pm       8 Jan 2004 04:54:06 -0000       1.135
+++ lib/Apache/TestRun.pm       8 Jan 2004 21:07:01 -0000
@@ -1291,6 +1291,11 @@
  sub custom_config_load {
      debug "trying to load custom config data";

+    if (Apache::TestConfig::IS_MOD_PERL_2_BUILD()) {
+        debug "modperl-2.0 build - ignore any custom config data";
+        return;
+    }
+
      if (my $custom_config_path = custom_config_path()) {
          debug "loading custom config path '$custom_config_path'";



__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


Mime
View raw message