httpd-test-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Geoffrey Young <ge...@modperlcookbook.org>
Subject mod_include test shuffling
Date Wed, 10 Dec 2003 05:39:05 GMT
well, since I know andre is paying attention, I thought I'd start with
mod_include :)

ok, I made some adjustments to t/modules/include.t to accommodate 1.3, 2.0,
and 2.1.  hopefully, all I did was shuffle things around so that it's easier
to keep track of the three cases: proper behavior, in-process fixes, and
will-never-be-fixed-in-this-version.  for the most part, these were all
documented by andre so all I ended up doing was (hopefully) making later
bookeeping a bit easier for everyone.

so, here are before and after outputs (note the failure numbers are
different due to a new ordering):

1.3 before:
modules/include....NOK 18# Failed test 18 in modules/include.t at line 127
fail #18
modules/include....NOK 35# Failed test 35 in modules/include.t at line 127
fail #35
modules/include....ok 42/76# Failed test 42 in modules/include.t at line 207
*TODO*

1.3 after:
modules/include....ok 20/76# Failed test 20 in modules/include-geoff.t at
line 223 fail #18 *TODO*
modules/include....ok 39/76# Failed test 39 in modules/include-geoff.t at
line 223 fail #37 *TODO*
modules/include....ok 43/76# Failed test 43 in modules/include-geoff.t at
line 272 *TODO*
modules/include....ok
        14/76 skipped: Skipping bucket boundary tests, no mod_bucketeer
All tests successful, 14 subtests skipped.


2.0 before:

modules/include....NOK 9# Failed test 9 in modules/include.t at line 127 fail #9
modules/include....NOK 18# Failed test 18 in modules/include.t at line 127
fail #18
modules/include....NOK 33# Failed test 33 in modules/include.t at line 127
fail #33
modules/include....NOK 35# Failed test 35 in modules/include.t at line 127
fail #35
modules/include....NOK 36# Failed test 36 in modules/include.t at line 127
fail #36
modules/include....NOK 41# Failed test 41 in modules/include.t at line 150


2.0 after:
modules/include....ok 11/81# Failed test 11 in modules/include-geoff.t at
line 223 fail #9 *TODO*
modules/include....ok 22/81# Failed test 22 in modules/include-geoff.t at
line 223 fail #18 *TODO*
modules/include....ok 27/81# Failed test 27 in modules/include-geoff.t at
line 223 fail #23 *TODO*
modules/include....ok 39/81# Failed test 39 in modules/include-geoff.t at
line 223 fail #35 *TODO*
modules/include....ok 41/81# Failed test 41 in modules/include-geoff.t at
line 223 fail #37 *TODO*
modules/include....ok 42/81# Failed test 42 in modules/include-geoff.t at
line 223 fail #38 *TODO*
modules/include....ok
        14/81 skipped: Skipping bucket boundary tests, no mod_bucketeer,
1/81 unexpectedly succeeded
All tests successful (1 subtest UNEXPECTEDLY SUCCEEDED), 14 subtests skipped.


2.1 before:
modules/include....ok
        14/82 skipped: Skipping bucket boundary tests, no mod_bucketeer,
1/82 unexpectedly succeeded
All tests successful (1 subtest UNEXPECTEDLY SUCCEEDED), 14 subtests skipped.

2.1 after:
modules/include....ok
        14/82 skipped: Skipping bucket boundary tests, no mod_bucketeer
All tests successful, 14 subtests skipped.


the only place I'm a bit confused is the flastmod/fsize test, which is
marked as TODO currently but is "unexpectedly passing" in 2.0/2.1.  the
comments make it sound like large sizes should fail in 2.0, but I created
all sizes up to 2GB and it still didn't fail (after conversions were taken
into account).  what is that test actually testing, the commifying and K/M/G
rounding?  ideally, if 2.0 is still buggy, what I'd like to see there is a
tests that passes in 2.1 but fails in 2.0 so we can mark it as TODO in 2.0
as well.

anyway, I know the changes are largish - certainly more than I had
anticipated - but I hope it's a bit cleaner and easier to maintain.  I
definitely don't mean to trample on your work, so feedback is very welcome.

oh, and I'm very impressed with the thoroughness of the tests, btw.  nice work.

--Geoff

Mime
View raw message