Return-Path: Delivered-To: apmail-httpd-test-dev-archive@www.apache.org Received: (qmail 26507 invoked from network); 26 Nov 2003 00:06:26 -0000 Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12) by minotaur-2.apache.org with SMTP; 26 Nov 2003 00:06:26 -0000 Received: (qmail 44946 invoked by uid 500); 26 Nov 2003 00:05:58 -0000 Delivered-To: apmail-httpd-test-dev-archive@httpd.apache.org Received: (qmail 44920 invoked by uid 500); 26 Nov 2003 00:05:58 -0000 Mailing-List: contact test-dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: test-dev@httpd.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list test-dev@httpd.apache.org Received: (qmail 44891 invoked from network); 26 Nov 2003 00:05:57 -0000 Received: from unknown (HELO mail.logilune.com) (195.154.174.52) by daedalus.apache.org with SMTP; 26 Nov 2003 00:05:57 -0000 Received: from stason.org (localhost.logilune.com [127.0.0.1]) by mail.logilune.com (Postfix) with ESMTP id 349F5799A0 for ; Wed, 26 Nov 2003 01:06:03 +0100 (CET) Message-ID: <3FC3EF18.8010004@stason.org> Date: Tue, 25 Nov 2003 16:08:56 -0800 From: Stas Bekman Organization: Hope, Humanized User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030630 X-Accept-Language: en-us, en, he, ru MIME-Version: 1.0 To: test-dev@httpd.apache.org Subject: Re: [Patch] Handle RedHat style Include conf.d/*.conf default configuration References: <1069718057.4324.22.camel@localhost.localdomain> <3FC2A04B.1020102@stason.org> <1069791276.15462.20.camel@localhost.localdomain> In-Reply-To: <1069791276.15462.20.camel@localhost.localdomain> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Philippe M. Chiasson wrote: [...] >>+1 after doing a proper indentation ;) please get rid of those tabs! and see >>below: > > > Sorry, millions of apologies, my editor popped on me ;-( And it's still off by one in your new patch... have you considered getting a decent editor? ;) > if ($directive eq "Include") { > - my $include = $self->server_file_rel2abs($_); > - $self->inherit_config_file_or_directory($include); > + foreach my $include (glob($self->server_file_rel2abs($_))) { > + $self->inherit_config_file_or_directory($include); ^^^ > + } > } other than that, +1. ;) __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:stas@stason.org http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com