httpd-test-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject Re: [Patch] Handle RedHat style Include conf.d/*.conf default configuration
Date Wed, 26 Nov 2003 00:08:56 GMT
Philippe M. Chiasson wrote:
[...]
>>+1 after doing a proper indentation ;) please get rid of those tabs! and see 
>>below:
> 
> 
> Sorry, millions of apologies, my editor popped on me ;-(

And it's still off by one in your new patch... have you considered getting a 
decent editor? ;)

>          if ($directive eq "Include") {
> -            my $include = $self->server_file_rel2abs($_);
> -            $self->inherit_config_file_or_directory($include);
> +            foreach my $include (glob($self->server_file_rel2abs($_))) {
> +               $self->inherit_config_file_or_directory($include);
                ^^^
> +            }
>          }

other than that, +1. ;)


__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


Mime
View raw message