httpd-test-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Geoffrey Young <ge...@modperlcookbook.org>
Subject Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfigParse.pm
Date Fri, 07 Nov 2003 18:59:47 GMT


Stas Bekman wrote:
> geoff@apache.org wrote:
> 
>> geoff       2003/11/07 07:03:39
>>
>>   Modified:    perl-framework/Apache-Test/lib/Apache TestConfigParse.pm
>>   Log:
>>   use apxs PREFIX to resolve relative httpd.conf directives
>>   ServerRoot is not present
>>     Revision  Changes    Path
>>   1.36      +48 -6     
>> httpd-test/perl-framework/Apache-Test/lib/Apache/TestConfigParse.pm
>>     Index: TestConfigParse.pm
> 
> [...]
> 
>>   +        else {
>>   +            warning "unable to resolve $file - cannot find a 
>> suitable ServerRoot";
>>   +            warning "please specify a ServerRoot in your httpd.conf 
>> or use apxs";
> 
> 
> shouldn't this be an error message (not fatal, just s/warning/error/)

well, I was thinking about that lots.  the reason I went with warning is 
that under normal circumstances 'perl Makefile.PL' would be the one throwing 
the message, but it's really not a build-time problem.  actually, the 
'errors' might not end up being errors at all - if the configuration script 
can't resolve conf/mime.types, for instance, but the EU has one in his 
t/conf directory everything should work out fine.

so, given this, I thought warnings were more appropriate.  but I'm flexible 
and don't feel too strongly about it.

--Geoff


Mime
View raw message