httpd-test-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Geoffrey Young <ge...@modperlcookbook.org>
Subject Re: [PATCH] allow implicit ServerRoot via apxs
Date Tue, 04 Nov 2003 20:43:31 GMT

>>> and it's an absolute_path.
>>
>>
>>
>> no sense checking that - rel2abs returns an absolute path by definition.
> 
> 
> what if it fails?

the call to rel2abs?  since it does no check of the underlying filesystem I 
doubt that's realistic.

I'm definitely a fan of error checking where it makes sense, but I also 
think it's safe to rely on APIs to do what they say.  we don't go checking 
calls to catfile to make sure the result has slashes in them :)

> 
>>> or die otherwise.
>>
>>
>>
>> I don't think we should die here - it's not fatal to the build process 
>> if 'perl Makefile.PL' can't resolve testing files.
> 
> 
> Hmm, look at your patch, you die if there is no base. I was just 
> following your idea ;)

oops, I meant to take that out - as you can see, though, I was thinking 
about whether it was ok to die here ;)

it seem, though, that everyone is kinda happy with putting the logic change 
here, so I'll work these changes up and submit something new soonish.

--Geoff


Mime
View raw message