httpd-test-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject Re: [PATCH] allow implicit ServerRoot via apxs
Date Tue, 04 Nov 2003 19:57:24 GMT
Geoffrey Young wrote:
[...]
> +        elsif ($base = $self->apxs('PREFIX')) {
> +            warning "using apxs-derived ServerRoot $base to resolve $file";

May be better to say it all?

           warning "since ServerRoot is not defined, " .
               "using apxs-derived PREFIX $base to resolve $file";

While you are at it, I'd also add a check that $base exists and it's a 
directory before you call rel2abs, because it can be a broken value. And also 
check that rel2abs gives us a an existing filename and it's an absolute_path. 
or die otherwise.


__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


Mime
View raw message