httpd-test-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philippe M. Chiasson" <go...@cpan.org>
Subject Re: [Patch] Handle RedHat style Include conf.d/*.conf default configuration
Date Wed, 26 Nov 2003 01:12:55 GMT
On Tue, 2003-11-25 at 16:08, Stas Bekman wrote:
> Philippe M. Chiasson wrote:
> [...]
> >>+1 after doing a proper indentation ;) please get rid of those tabs! and see

> >>below:
> > 
> > 
> > Sorry, millions of apologies, my editor popped on me ;-(
> 
> And it's still off by one in your new patch... have you considered getting a 
> decent editor? ;)

I don't want to even start thinking about Emacs dude ;-) I prefer to put
the blame on me, not my editor, sorry ;-)

> >          if ($directive eq "Include") {
> > -            my $include = $self->server_file_rel2abs($_);
> > -            $self->inherit_config_file_or_directory($include);
> > +            foreach my $include (glob($self->server_file_rel2abs($_))) {
> > +               $self->inherit_config_file_or_directory($include);
>                 ^^^
> > +            }
> >          }
> 
> other than that, +1. ;)

Changed and comitted then ;-)

> 
> __________________________________________________________________
> Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
> http://stason.org/     mod_perl Guide ---> http://perl.apache.org
> mailto:stas@stason.org http://use.perl.org http://apacheweek.com
> http://modperlbook.org http://apache.org   http://ticketmaster.com
-- 
--------------------------------------------------------------------------------
Philippe M. Chiasson /gozer\@(cpan|ectoplasm)\.org/ 88C3A5A5 (122FF51B/C634E37B)
http://gozer.ectoplasm.org/    F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3 A5A5
Q: It is impossible to make anything foolproof because fools are so ingenious.
perl -e'$$=\${gozer};{$_=unpack(P7,pack(L,$$));/^JAm_pH\n$/&&print||$$++&&redo}'

Mime
View raw message