Mailing-List: contact test-dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: test-dev@httpd.apache.org
Message-ID: <3F620AAB.7020009@stason.org>
Date: Fri, 12 Sep 2003 11:04:27 -0700
From: Stas Bekman <stas@stason.org>
Organization: Hope, Humanized
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030630
MIME-Version: 1.0
To: Boris Zentner <boris@ambient-entertainment.de>,
	httpd-test-dev list <test-dev@httpd.apache.org>
Subject: Re: Apache::Test
References: <200309111515.49838.boris@ambient-entertainment.de>
In-Reply-To: <200309111515.49838.boris@ambient-entertainment.de>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

[redirecting it to the httpd-test dev list where this discussion belongs]

Boris Zentner wrote:
> Hi Stas,
> 
> I spend the morning on porting Apache::PageKit to Apache::Test and make the 
> installation of this large module easy. My idea to support perl < 5.8 and >= 
> 5.8 was to use patch inside the makefile and make the changes to my files 
> after they are copied to the blib directory. So the original files are avail 
> everytime. Im not really sure if this is a good way, but it stopped working 
> on the 'make test' part since on some configurations the content of
> Apache-PageKit/lib is not the same as Apache-PageKit/blib but Apache::Test use 
> Apache-PageKit/lib instead Apache-PageKit/blib. I think this is wrong since 
> if all goes well I install the content of Apache-PageKit/blib and this is not 
> what I tested.
> 
> I attach a patch that fix it for me. The above comment seems also misleading.

The idea is to allow developers to test against the live files under lib, to 
make it possible to develop while running the test suite. I use this feature 
all the time in combination with Apache::Reload. You are right that we want to 
test against the blib when users run 'make test'. Purhaps we should make it 
configurable, so it's not hardwired? e.g. we could have an environment 
variable APACHE_TEST_DEV_MODE which when set will add the non-blib dirs to @INC.

> BTW: Apache::Test is very powerfull. I had a lot of ideas that I can test now. 
> Very easy. Thanks a lot. 

Thanks ;)

> But you should add this pod 
> 'Running and Developing Tests with the Apache::Test Framework'
> with Apache::Test. If I had not found that document, I never used 
> Apache::Test. And it is soooo usefull. Please consider to put it in.

The pointer to that document is at the very beginning of Apache-Test/README, 
it's hard to miss it.

> Have a nice day.
> 
> 
> ------------------------------------------------------------------------
> 
> diff -Nur Apache-Test-1.03.old/lib/Apache/TestConfig.pm Apache-Test-1.03/lib/Apache/TestConfig.pm
> --- Apache-Test-1.03.old/lib/Apache/TestConfig.pm	2003-09-11 14:58:04.000000000 +0200
> +++ Apache-Test-1.03/lib/Apache/TestConfig.pm	2003-09-11 15:08:14.000000000 +0200
> @@ -1404,7 +1404,7 @@
>      # followed by modperl's lib, followed by blib and finally core
>      # Perl libs.
>      lib::->import(map "$self->{vars}->{top_dir}/$_",
> -                  qw(Apache-Test/lib lib blib/lib blib/arch));
> +                  qw(Apache-Test/lib blib/lib blib/arch lib));
>      #print join "\n", "add_inc", @INC, "";
>  }
>  


-- 


__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com