httpd-test-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From André Malo ...@perlig.de>
Subject Re: [PATCH] let perl-framework create name based VirtualHosts
Date Tue, 12 Aug 2003 20:48:55 GMT
* Stas Bekman wrote:

> +1, but see a few minor code comments below

well, some further comments below.

> my @out_config = ();
> 
> since it might be used later without anything pushed in (so it'd be undef).

an array can't be undef, but I've no problem to add the =() to make it obvious
;-)

>>>+    if ($self->{vhosts}->{$module}->{namebased} < 2) {
>>>+        #extra config that should go *outside* the <VirtualHost ...>
>>>+        @out_config = ([Listen => $port]);
> 
> but originally that code was always running, why it's conditioned? shouldn't
> it always run?

No. If you have more than one VH at one port, you need *one* Listen, no more.

> indent:
> 
> +        line          => "$indent<VirtualHost " . ($namebased ? '*' :
> '_default_').

I'm assuming you didn't write the linebreak. So isn't a 80 char/line limit
here?

>>>+        ++$vhost->{namebased};
> 
> normally we used to write i++ in perl, but it's fine as well ;)

Heh, the optimizer probably does it's work ;) Okay.

nd

Mime
View raw message