httpd-test-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject Re: [PATCH] let perl-framework create name based VirtualHosts
Date Tue, 12 Aug 2003 20:59:56 GMT
André Malo wrote:
> * Stas Bekman wrote:
> 
> 
>>+1, but see a few minor code comments below
> 
> 
> well, some further comments below.
> 
> 
>>my @out_config = ();
>>
>>since it might be used later without anything pushed in (so it'd be undef).
> 
> 
> an array can't be undef, but I've no problem to add the =() to make it obvious
> ;-)

let's go with the second ;)

>>>>+    if ($self->{vhosts}->{$module}->{namebased} < 2) {
>>>>+        #extra config that should go *outside* the <VirtualHost ...>
>>>>+        @out_config = ([Listen => $port]);
>>
>>but originally that code was always running, why it's conditioned? shouldn't
>>it always run?
> 
> 
> No. If you have more than one VH at one port, you need *one* Listen, no more.

ok

>>indent:
>>
>>+        line          => "$indent<VirtualHost " . ($namebased ? '*' :
>>'_default_').
> 
> 
> I'm assuming you didn't write the linebreak. So isn't a 80 char/line limit
> here?

no, no, just adding spacing for ./?/: ops.

__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


Mime
View raw message