Return-Path: Delivered-To: apmail-httpd-test-dev-archive@httpd.apache.org Received: (qmail 61029 invoked by uid 500); 11 Jul 2003 01:00:24 -0000 Mailing-List: contact test-dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: test-dev@httpd.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list test-dev@httpd.apache.org Received: (qmail 61018 invoked from network); 11 Jul 2003 01:00:24 -0000 Message-ID: <3F0E0C42.5060500@stason.org> Date: Thu, 10 Jul 2003 18:00:50 -0700 From: Stas Bekman Organization: Hope, Humanized User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030313 X-Accept-Language: en-us, en MIME-Version: 1.0 To: test-dev@httpd.apache.org Subject: Re: [PATCH] Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestRequest.pm References: In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N Sander Temme wrote: > on 7/10/03 12:56, Sander Temme at sctemme@covalent.net wrote: > > >>parameter to the request invocations in t/apache/acceptpathinfo.t. Neither >>produces any result. Am I looking in the right place? > > > Breadcrumbing my way through Apache-Test/lib/Apache/TestRequest.pm by > liberally sprinkling print statements, I get to the following around line > 97: > > >>>+ if (my $redir = $args->{requests_redirectable}) { >>>+ if (ref $redir and (@$redir > 1 or $redir->[0] ne 'POST')) { >>>+ $RedirectOK = 1; >>>+ } else { >>>+ $RedirectOK = 0; >>>+ } >>>+ } else { >>>+ $RedirectOK = $redir; >>>+ } >>>+ > > > We arrive at this if statement in all failing acceptpathinfo and > modules/alias tests, and end up in the else clause because $redir is > undefined. The result is that we reset RedirectOK to something undefined, > hence don't follow the redirection. Getting rid of the else clause gets me > my passing tests back, since RedirectOK stays at its default value of '1'. > Like so: > > Index: Apache-Test/lib/Apache/TestRequest.pm > =================================================================== > RCS file: > /home/cvspublic/httpd-test/perl-framework/Apache-Test/lib/Apache/TestRequest > .pm,v > retrieving revision 1.81 > diff -u -r1.81 TestRequest.pm > --- Apache-Test/lib/Apache/TestRequest.pm 8 Jul 2003 07:56:24 -0000 > 1.81 > +++ Apache-Test/lib/Apache/TestRequest.pm 10 Jul 2003 21:05:34 -0000 > @@ -94,8 +94,6 @@ > } else { > $RedirectOK = 0; > } > - } else { > - $RedirectOK = $redir; > } > > $args->{keep_alive} ||= $ENV{APACHE_TEST_HTTP11}; > > (also attached to avoid breakage by line wrappage). Tested on Darwin 6.6, > Perl 5.6.0, against Apache 2.0.47. > > Does that sound sound? Does this work? else if ($redir) { $RedirectOK = $redir; } __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:stas@stason.org http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com