httpd-test-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sander Temme <scte...@covalent.net>
Subject Re: [PATCH] Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestRequest.pm
Date Fri, 11 Jul 2003 16:27:07 GMT
on 7/11/03 9:06, David Wheeler at david@kineticode.com wrote:

> The above patch doesn't work. But this does:

Ehm... works for me. I think you're working in the mod_perl space and I'm
just concentrating on the Apache core. Maybe there are side effects that I'm
not seeing? 
 
> --- TestRequest.pm.~1.81.~    Fri Jul 11 09:02:32 2003
> +++ TestRequest.pm    Fri Jul 11 09:03:59 2003
> @@ -95,7 +95,7 @@
>             $RedirectOK = 0;
>         }
>     } else {
> -        $RedirectOK = $redir;
> +        $RedirectOK = 0;
>     }
> 
>     $args->{keep_alive} ||= $ENV{APACHE_TEST_HTTP11};
> 
> IOW, $RedirectOK needs a value. Sender, does this work for you?

I don't think it will... I need redirect to be 1 under the circumstances
that I described: during those apache/acceptpathinfo and modules/alias tests
that need it. So, unless there is a compelling reason (like
$args->{requests_redirectable} existing and containing pertinent
information), we should leave $RedirectOK alone here.

S.

-- 
Covalent Technologies                             sctemme@covalent.net
Engineering group                                Voice: (415) 856 4214
303 Second Street #375 South                       Fax: (415) 856 4210
San Francisco CA 94107

   PGP Fingerprint: 7A8D B189 E871 80CB 9521  9320 C11E 7B47 964F 31D9

=======================================================
This email message is for the sole use of the intended recipient(s) and may
contain confidential and privileged information. Any unauthorized review,
use, disclosure or distribution is prohibited.  If you are not the intended
recipient, please contact the sender by reply email and destroy all copies
of the original message
=======================================================


Mime
View raw message