httpd-test-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sander Temme <scte...@covalent.net>
Subject Re: [PATCH] Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestRequest.pm
Date Fri, 11 Jul 2003 04:36:22 GMT
on 7/10/03 18:00, Stas Bekman at stas@stason.org wrote:

> 
> Does this work?
> 
> else if ($redir) {
>    $RedirectOK = $redir;
> }

It does. However, isn't this the same condition as in the top if clause?
Wouldn't you want to:

Index: Apache-Test/lib/Apache/TestRequest.pm
===================================================================
RCS file: 
/home/cvspublic/httpd-test/perl-framework/Apache-Test/lib/Apache/TestRequest
.pm,v
retrieving revision 1.81
diff -u -r1.81 TestRequest.pm
--- Apache-Test/lib/Apache/TestRequest.pm       8 Jul 2003 07:56:24 -0000
1.81
+++ Apache-Test/lib/Apache/TestRequest.pm       11 Jul 2003 04:28:45 -0000
@@ -88,14 +88,12 @@
         $UA = undef;
     }
 
-    if (my $redir = $args->{requests_redirectable}) {
+    if (defined (my $redir = $args->{requests_redirectable})) {
         if (ref $redir and (@$redir > 1 or $redir->[0] ne 'POST')) {
             $RedirectOK = 1;
         } else {
             $RedirectOK = 0;
         }
-    } else {
-        $RedirectOK = $redir;
     }
 
     $args->{keep_alive} ||= $ENV{APACHE_TEST_HTTP11};

In other words, if $redir is defined, do something with it to the effect of
$RedirectOK. If it isn't defined, go with the default value which is 1. What
exactly is this code trying to do?

S.

-- 
Covalent Technologies                             sctemme@covalent.net
Engineering group                                Voice: (415) 856 4214
303 Second Street #375 South                       Fax: (415) 856 4210
San Francisco CA 94107

   PGP Fingerprint: 7A8D B189 E871 80CB 9521  9320 C11E 7B47 964F 31D9

=======================================================
This email message is for the sole use of the intended recipient(s) and may
contain confidential and privileged information. Any unauthorized review,
use, disclosure or distribution is prohibited.  If you are not the intended
recipient, please contact the sender by reply email and destroy all copies
of the original message
=======================================================


Mime
View raw message