httpd-test-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sander Temme <scte...@covalent.net>
Subject [PATCH] Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestRequest.pm
Date Thu, 10 Jul 2003 21:11:09 GMT
on 7/10/03 12:56, Sander Temme at sctemme@covalent.net wrote:

> parameter to the request invocations in t/apache/acceptpathinfo.t. Neither
> produces any result. Am I looking in the right place?

Breadcrumbing my way through Apache-Test/lib/Apache/TestRequest.pm by
liberally sprinkling print statements, I get to the following around line
97:
 
>> +    if (my $redir = $args->{requests_redirectable}) {
>> +        if (ref $redir and (@$redir > 1 or $redir->[0] ne 'POST')) {
>> +            $RedirectOK = 1;
>> +        } else {
>> +            $RedirectOK = 0;
>> +        }
>> +    } else {
>> +        $RedirectOK = $redir;
>> +    }
>> +

We arrive at this if statement in all failing acceptpathinfo and
modules/alias tests, and end up in the else clause because $redir is
undefined. The result is that we reset RedirectOK to something undefined,
hence don't follow the redirection. Getting rid of the else clause gets me
my passing tests back, since RedirectOK stays at its default value of '1'.
Like so:

Index: Apache-Test/lib/Apache/TestRequest.pm
===================================================================
RCS file: 
/home/cvspublic/httpd-test/perl-framework/Apache-Test/lib/Apache/TestRequest
.pm,v
retrieving revision 1.81
diff -u -r1.81 TestRequest.pm
--- Apache-Test/lib/Apache/TestRequest.pm       8 Jul 2003 07:56:24 -0000
1.81
+++ Apache-Test/lib/Apache/TestRequest.pm       10 Jul 2003 21:05:34 -0000
@@ -94,8 +94,6 @@
         } else {
             $RedirectOK = 0;
         }
-    } else {
-        $RedirectOK = $redir;
     }
 
     $args->{keep_alive} ||= $ENV{APACHE_TEST_HTTP11};

(also attached to avoid breakage by line wrappage). Tested on Darwin 6.6,
Perl 5.6.0, against Apache 2.0.47.

Does that sound sound?

S.

-- 
Covalent Technologies                             sctemme@covalent.net
Engineering group                                Voice: (415) 856 4214
303 Second Street #375 South                       Fax: (415) 856 4210
San Francisco CA 94107

   PGP Fingerprint: 7A8D B189 E871 80CB 9521  9320 C11E 7B47 964F 31D9

=======================================================
This email message is for the sole use of the intended recipient(s) and may
contain confidential and privileged information. Any unauthorized review,
use, disclosure or distribution is prohibited.  If you are not the intended
recipient, please contact the sender by reply email and destroy all copies
of the original message
=======================================================


Mime
View raw message