httpd-test-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Wheeler <da...@kineticode.com>
Subject Re: [PATCH] Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestRequest.pm
Date Fri, 11 Jul 2003 16:06:53 GMT
On Friday, July 11, 2003, at 02:22  AM, Stas Bekman wrote:

>> diff -u -r1.81 TestRequest.pm
>> --- Apache-Test/lib/Apache/TestRequest.pm       8 Jul 2003 07:56:24 
>> -0000
>> 1.81
>> +++ Apache-Test/lib/Apache/TestRequest.pm       11 Jul 2003 04:28:45 
>> -0000
>> @@ -88,14 +88,12 @@
>>          $UA = undef;
>>      }
>>  -    if (my $redir = $args->{requests_redirectable}) {
>> +    if (defined (my $redir = $args->{requests_redirectable})) {
>>          if (ref $redir and (@$redir > 1 or $redir->[0] ne 'POST')) {
>>              $RedirectOK = 1;
>>          } else {
>>              $RedirectOK = 0;
>>          }
>> -    } else {
>> -        $RedirectOK = $redir;
>>      }
>>       $args->{keep_alive} ||= $ENV{APACHE_TEST_HTTP11};
>> In other words, if $redir is defined, do something with it to the 
>> effect of
>> $RedirectOK. If it isn't defined, go with the default value which is 
>> 1.
>
> Looks right to me. I was just looking at the diff that you've posted 
> earlier hence the awkward fixup suggestion. You probably don't even 
> need defined. I'll let David decide how he wants it.

Gee, thanks!

> David Wheeler was trying to make $RedirectOK to be a non-global flag, 
> so you can change it locally to your specific test. He will soonish 
> reply confirming whether this still works for him or not. I don't have 
> the test suite that he has, so I can't test.

The above patch doesn't work. But this does:

--- TestRequest.pm.~1.81.~	Fri Jul 11 09:02:32 2003
+++ TestRequest.pm	Fri Jul 11 09:03:59 2003
@@ -95,7 +95,7 @@
              $RedirectOK = 0;
          }
      } else {
-        $RedirectOK = $redir;
+        $RedirectOK = 0;
      }

      $args->{keep_alive} ||= $ENV{APACHE_TEST_HTTP11};

IOW, $RedirectOK needs a value. Sender, does this work for you?

Regards,

David

-- 
David Wheeler                                     AIM: dwTheory
david@kineticode.com                              ICQ: 15726394
http://kineticode.com/                         Yahoo!: dew7e
                                                Jabber: Theory@jabber.org
Kineticode. Setting knowledge in motion.[sm]


Mime
View raw message