httpd-test-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject Re: cvs commit: httpd-test/perl-framework/Apache-Test Changes
Date Tue, 20 May 2003 23:34:11 GMT
Sander Temme wrote:
> on 5/20/03 10:53, Sander Temme at sctemme@covalent.net wrote:
> 
> 
>>This breaks on RH 8.0 and Solaris 7, both on perl 5.8.0, with the following
> 
> 
> The following patch gets me back in the saddle, not only on Linux/Solaris
> but also on Darwin 6.6:
> 
> Index: Apache-Test/lib/Apache/TestConfig.pm
> ===================================================================
> RCS file: 
> /home/cvspublic/httpd-test/perl-framework/Apache-Test/lib/Apache/TestConfig.
> pm,v
> retrieving revision 1.162
> diff -u -r1.162 TestConfig.pm
> --- Apache-Test/lib/Apache/TestConfig.pm        20 May 2003 06:01:38 -0000
> 1.162
> +++ Apache-Test/lib/Apache/TestConfig.pm        20 May 2003 18:18:08 -0000
> @@ -781,7 +781,7 @@
>          push @dirs, '../lib';
>      }
>  
> -    push @dirs, 'Apache-Test' if IS_MOD_PERL_2_BUILD;
> +    push @dirs, 'Apache-Test/lib';
>  
>      return <<"EOF";
>  
> I'm not building mod_perl, so that Apache-Test did not get included on
> Darwin (running perl 5.6.0 which apparently doesn't choke on the constant)
> and furthermore it needs to be Apache-Test/lib.
> 
> Please let me know if I'm onto something, or merely on something.

Yes, yes, I've messed things up a bit. My goal was to cleanup @INC from 
non-existing dirs. Therefore can you try this patch:

Index: Apache-Test/lib/Apache/TestConfig.pm
===================================================================
RCS file: 
/home/cvs/httpd-test/perl-framework/Apache-Test/lib/Apache/TestConfig.pm,v
retrieving revision 1.162
diff -u -r1.162 TestConfig.pm
--- Apache-Test/lib/Apache/TestConfig.pm        20 May 2003 06:01:38 -0000 
  1.162
+++ Apache-Test/lib/Apache/TestConfig.pm        20 May 2003 23:33:27 -0000
@@ -781,7 +781,13 @@
          push @dirs, '../lib';
      }

-    push @dirs, 'Apache-Test' if IS_MOD_PERL_2_BUILD;
+    for (qw(. ..)) {
+        my $dir = catdir $FindBin::Bin, "..", $_ , "Apache-Test", "lib";
+        if (-d $dir) {
+            push @dirs, $dir;
+            last;
+        }
+    }

      return <<"EOF";




__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


Mime
View raw message