Return-Path: Delivered-To: apmail-httpd-test-dev-archive@httpd.apache.org Received: (qmail 14980 invoked by uid 500); 11 Apr 2003 23:52:28 -0000 Mailing-List: contact test-dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: test-dev@httpd.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list test-dev@httpd.apache.org Received: (qmail 14952 invoked from network); 11 Apr 2003 23:52:27 -0000 Message-ID: <3E975544.3030202@stason.org> Date: Sat, 12 Apr 2003 09:52:36 +1000 From: Stas Bekman Organization: Hope, Humanized User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.1) Gecko/20020826 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Geoffrey Young Cc: dev@perl.apache.org, test-dev@httpd.apache.org Subject: Re: [patch] optional exports from Apache::TestUtil References: <3E96BF05.2000502@modperlcookbook.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N Geoffrey Young wrote: > hi all... > > I don't see why Apache::TestUtil exports so many functions by default, > yet it leaves out three that are just as helpful. Because there are private functions (think of these as _foo). Do you need them? > attached is a patch that makes the public, non t_* functions exportable > on demand. > > --Geoff > > > ------------------------------------------------------------------------ > > Index: Apache-Test/lib/Apache/TestUtil.pm > =================================================================== > RCS file: /home/cvspublic/httpd-test/perl-framework/Apache-Test/lib/Apache/TestUtil.pm,v > retrieving revision 1.29 > diff -u -r1.29 TestUtil.pm > --- Apache-Test/lib/Apache/TestUtil.pm 1 Apr 2003 04:12:55 -0000 1.29 > +++ Apache-Test/lib/Apache/TestUtil.pm 11 Apr 2003 12:51:25 -0000 > @@ -15,7 +15,7 @@ > use Apache::Test (); > use Apache::TestConfig (); > > -use vars qw($VERSION @ISA @EXPORT %CLEAN); > +use vars qw($VERSION @ISA @EXPORT @EXPORT_OK %CLEAN); > > $VERSION = '0.01'; > @ISA = qw(Exporter); > @@ -25,6 +25,8 @@ > t_server_log_error_is_expected t_server_log_warn_is_expected > t_client_log_error_is_expected t_client_log_warn_is_expected > ); > + > +@EXPORT_OK = qw(write_perl_script write_shell_script chown); > > %CLEAN = (); > > > > > ------------------------------------------------------------------------ > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org > For additional commands, e-mail: dev-help@perl.apache.org -- __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:stas@stason.org http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com