Mailing-List: contact test-dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: test-dev@httpd.apache.org
Errors-To: <wrowe@rowe-clan.net>
Message-Id: <5.2.0.9.2.20030128235031.0355aea0@pop3.rowe-clan.net>
Date: Tue, 28 Jan 2003 23:51:31 -0600
To: test-dev@httpd.apache.org
From: "William A. Rowe, Jr." <wrowe@rowe-clan.net>
Subject: Re: [PATCH] flood: Fixed Win32 crash resulting from strtoll()
  macro.
In-Reply-To: <20030129015229.6E51B194A9@chickenfeet.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"

Nice patch, ++1.

At 07:52 PM 1/28/2003, ptran@pobox.com wrote:
>This patch is the first in a series that will produce a running
>executable on Win32 platforms with Microsoft Visual C++ 6.0.
>My Win32 development environment is Microsoft Windows 2000
>Service Pack 3 and MS Visual C++ 6.0 Service Pack 3.  My FLOOD
>source was checked out from CVS this morning.
>
>Summary:
>  * Fixed Win32 crash resulting from strtoll() macro.
>
>This patch addresses a crash caused by the Win32 implementation
>of the strtoll() macro in config.h, which is generated from
>config.h.in.  This patch fixes config.h.in.  The change will
>affect files using strtoll() on Win32 builds with an "old enough"
>Microsoft Visual C/C++ compiler.
>
>Index: config.h.in
>===================================================================
>RCS file: /home/cvspublic/httpd-test/flood/config.h.in,v
>retrieving revision 1.25
>diff -u -r1.25 config.h.in
>--- config.h.in 16 Sep 2002 09:55:07 -0000      1.25
>+++ config.h.in 29 Jan 2003 00:20:00 -0000
>@@ -74,7 +74,7 @@
> #ifdef WIN32
> /* Gross Hack Alert */
> #if _MSC_VER < 1300
>-#define strtoll(p, e, b) ((*(e) = (char*)(p) + ((b) == 10) ? strspn((p), "0123456789") : 0), _atoi64(p))
>+#define strtoll(p, e, b) ((*(e) = (char*)(p) + (((b) == 10) ? strspn((p), "0123456789") : 0)), _atoi64(p))
> #else
> #define strtoll(p, e, b) _strtoi64(p, e, b) 
> #endif