httpd-test-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Geoffrey Young <ge...@modperlcookbook.org>
Subject Re: [PATCH] make test TEST_VERBOSE=1
Date Wed, 18 Sep 2002 18:39:49 GMT


Doug MacEachern wrote:
>>     return $preamble . <<'EOF';
>>+ifdef TEST_VERBOSE
>>+  override TEST_VERBOSE = -verbose
>>+endif
> 
> 
> pretty sure ifdef/endif/override/ifeq are not portable (gmake-isms)

ah, right.

> 
> better to have the Makefile run 't/TEST -verbose=$(TEST_VERBOSE)'
> 
> of course, would still want 't/TEST -v' to work as it does now (turning 
> verbose on).  -verbose=0 should be off and -verbose=1 on if possible.

I think the attached patch behaves as suggested.

--Geoff


Mime
View raw message