Return-Path: Delivered-To: apmail-httpd-test-dev-archive@httpd.apache.org Received: (qmail 98283 invoked by uid 500); 9 Nov 2001 01:44:03 -0000 Mailing-List: contact test-dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: test-dev@httpd.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list test-dev@httpd.apache.org Received: (qmail 98272 invoked from network); 9 Nov 2001 01:44:02 -0000 Message-ID: <3BEB34E7.3010105@stason.org> Date: Fri, 09 Nov 2001 09:44:07 +0800 From: Stas Bekman Organization: Hope, Humanized User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.5) Gecko/20011012 X-Accept-Language: en-us MIME-Version: 1.0 To: test-dev@httpd.apache.org Subject: Re: [patch take3] add test skipping reasoning References: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N Doug MacEachern wrote: > On Thu, 8 Nov 2001, Stas Bekman wrote: > > patch doesn't apply for me, but looks good so just commit and .. done >>+ my @reasons = (); >> for (@modules) { >>+ my $reason; >> if (/^[a-z0-9_]+$/) { >> > > not sure if your mail has munged the patch, but indentation looks off like > this everywhere. I've moved to mozilla-mail recently, as it supports offline email with imap. Unfortunately it doesn't seem to handle properly inlined copy-n-paste :( yet >>+ skip_unless(sub { $perlpod }, "dir $perlpod doesn't exist"); >> > > '$perlpod' should be '$vars->{perlpod}' in the reason string, since > $perlpod is undef if the dir doesn't exist. oops, fixed. thanks _____________________________________________________________________ Stas Bekman JAm_pH -- Just Another mod_perl Hacker http://stason.org/ mod_perl Guide http://perl.apache.org/guide mailto:stas@stason.org http://ticketmaster.com http://apacheweek.com http://singlesheaven.com http://perl.apache.org http://perlmonth.com/