httpd-test-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject Re: cvs commit: httpd-test/perl-framework/t/modules env.t
Date Sat, 20 Oct 2001 03:16:05 GMT
dougm@apache.org wrote:

> dougm       01/10/19 17:54:14
> 
>   Modified:    perl-framework/t/modules env.t
>   Log:
>   fix for win32; s/[\r\n]+// rather than chomp


May be keeping chomp and setting $/ to \r\n for WIN? I thought chomp 
will do the right thing on any platform. I know that it just removes $/, 
but shouldn't it by default be set to \r\n on WIN and \r on Mac?


>   Revision  Changes    Path
>   1.10      +1 -1      httpd-test/perl-framework/t/modules/env.t
>   
>   Index: env.t
>   ===================================================================
>   RCS file: /home/cvs/httpd-test/perl-framework/t/modules/env.t,v
>   retrieving revision 1.9
>   retrieving revision 1.10
>   diff -u -r1.9 -r1.10
>   --- env.t	2001/09/18 15:41:03	1.9
>   +++ env.t	2001/10/20 00:54:14	1.10
>   @@ -29,7 +29,7 @@
>        $expected = $test{$_} || 'ERROR EXPECTED UNDEFINED';
>        sok {
>            $actual = GET_BODY "/modules/env/$_.shtml";
>   -        chomp $actual;
>   +        $actual =~ s/[\r\n]+$//s;
>            print "$_: EXPECT ->$expected<- ACTUAL ->$actual<-\n";
>            return $actual eq $expected;
>        };
>   
>   
>   
> 



-- 


_____________________________________________________________________
Stas Bekman             JAm_pH      --   Just Another mod_perl Hacker
http://stason.org/      mod_perl Guide   http://perl.apache.org/guide
mailto:stas@stason.org  http://ticketmaster.com http://apacheweek.com
http://singlesheaven.com http://perl.apache.org http://perlmonth.com/



Mime
View raw message