httpd-test-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject Re: [patch] Re: Apache-Test breakage
Date Fri, 19 Oct 2001 02:21:49 GMT
Doug MacEachern wrote:

> On Thu, 18 Oct 2001, Stas Bekman wrote:
>  
> 
>>So it works when you run ./t/TEST, but when you run 'make test', for 
>>some reason Makefile doesn't abort on exit from test_clean target, no 
>>matter if I put exit -1, 0 or 1, and proceeds with run_tests target. 
>>Does that have anything to do with the installed __DIE__ sighandler?
>>
> 
> probably, since __DIE__ will stop the server.  where did you put the
> exit(1) call?  i think it should work in the __DIE__ handler.


the exit call is in the $@ handling code:

+    eval { $self->configure; };
+    if ($@) {
+        error "configure() has failed:\n$@";
+        warning "forcing Apache::TestConfig object save";
+        $self->{test_config}->save;
+        warning "run 't/TEST -clean' to clean up before continuing";
+        exit;

         ^^^^^^^

+    }


Am I correct to say that if Makefile has:

C: A B

and A's return status is not 0, make will abort? I know that I've 
committed exit; but I've tried 1 and -1 without any effect. Any ideas 
why this happens? If you want an easy way to simulate breakage just do this:

Index: Apache-Test/lib/Apache/TestConfigPerl.pm
===================================================================
RCS file: 
/home/cvs/httpd-test/perl-framework/Apache-Test/lib/Apache/TestConfigPerl.pm,v
retrieving revision 1.38
diff -u -r1.38 TestConfigPerl.pm
--- Apache-Test/lib/Apache/TestConfigPerl.pm    2001/10/18 04:18:16     1.38
+++ Apache-Test/lib/Apache/TestConfigPerl.pm    2001/10/19 02:14:56
@@ -347,6 +347,7 @@
      if (open $fh, $file) {
          my $content = <$fh>;
          close $fh;
+        require $file;
          if ($content =~ /APACHE_TEST_CONFIGURE/m) {
              eval { require $file };
              warn $@ if $@;


_____________________________________________________________________
Stas Bekman             JAm_pH      --   Just Another mod_perl Hacker
http://stason.org/      mod_perl Guide   http://perl.apache.org/guide
mailto:stas@stason.org  http://ticketmaster.com http://apacheweek.com
http://singlesheaven.com http://perl.apache.org http://perlmonth.com/


Mime
View raw message