Return-Path: Delivered-To: apmail-httpd-test-dev-archive@httpd.apache.org Received: (qmail 30024 invoked by uid 500); 29 Aug 2001 17:02:47 -0000 Mailing-List: contact test-dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: test-dev@httpd.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list test-dev@httpd.apache.org Received: (qmail 29998 invoked from network); 29 Aug 2001 17:02:46 -0000 X-Authentication-Warning: slippy.rat: gbenson owned process doing -bs Date: Wed, 29 Aug 2001 18:02:43 +0100 (BST) From: Gary Benson Sender: To: Subject: Re: Core dump scan breaks exit() status In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N On Wed, 29 Aug 2001, Stas Bekman wrote: > On Wed, 29 Aug 2001, Stas Bekman wrote: > > > > > > The change was made in revision 1.28 of TestRun.pm, if you want to have a > > > > > look at it yourself. I have no idea how to fix this in a nice way, short > > > > > of moving it into a wrapper that runs t/TEST, remembers the exit status, > > > > > then checks for coredumps afterwards and then exits accordingly. > > > > > > > > I guess you are talking about the END block: > > > > > > > > eval "END { > > > > eval { > > > > Apache::TestRun->new(test_config => > > > > Apache::TestConfig->thaw)->scan; > > > > }; > > > > }"; > > > > > > > > but what exit status was it returning before? I don't think we have any > > > > definition of the exit status definitions according to the tests success > > > > or failure. Or do we? > > > > > > At the moment (or at least before that END block was there) it returns 1 > > > if something breaks. > > > > I see, try this patch (untested): > > I didn't realize that END {} is a block already :) here is a simpler patch > (still untested): > > Index: Apache-Test/lib/Apache/TestRun.pm > =================================================================== > RCS file: /home/cvs/httpd-test/perl-framework/Apache-Test/lib/Apache/TestRun.pm,v > retrieving revision 1.41 > diff -u -r1.41 TestRun.pm > --- Apache-Test/lib/Apache/TestRun.pm 2001/08/27 05:55:17 1.41 > +++ Apache-Test/lib/Apache/TestRun.pm 2001/08/29 15:49:48 > @@ -221,6 +221,7 @@ > #always run, a subclass might not want that > > eval "END { > + local $?; # preserve the exit status > eval { > Apache::TestRun->new(test_config => > Apache::TestConfig->thaw)->scan; Stas, thanks, that worked a treat. May I request that you commit it? Gary [ Gary Benson, Red Hat Europe ][ gbenson@redhat.com ][ GnuPG 60E8793A ]