httpd-test-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject Re: Core dump scan breaks exit() status
Date Wed, 29 Aug 2001 15:26:59 GMT
> > > The change was made in revision 1.28 of TestRun.pm, if you want to have a
> > > look at it yourself. I have no idea how to fix this in a nice way, short
> > > of moving it into a wrapper that runs t/TEST, remembers the exit status,
> > > then checks for coredumps afterwards and then exits accordingly.
> >
> > I guess you are talking about the END block:
> >
> >     eval "END {
> >              eval {
> >                 Apache::TestRun->new(test_config =>
> >                                      Apache::TestConfig->thaw)->scan;
> >              };
> >          }";
> >
> > but what exit status was it returning before? I don't think we have any
> > definition of the exit status definitions according to the tests success
> > or failure. Or do we?
>
> At the moment (or at least before that END block was there) it returns 1
> if something breaks.

I see, try this patch (untested):

Index: Apache-Test/lib/Apache/TestRun.pm
===================================================================
RCS file: /home/cvs/httpd-test/perl-framework/Apache-Test/lib/Apache/TestRun.pm,v
retrieving revision 1.41
diff -u -r1.41 TestRun.pm
--- Apache-Test/lib/Apache/TestRun.pm	2001/08/27 05:55:17	1.41
+++ Apache-Test/lib/Apache/TestRun.pm	2001/08/29 15:28:02
@@ -221,10 +221,13 @@
     #always run, a subclass might not want that

     eval "END {
-             eval {
-                Apache::TestRun->new(test_config =>
-                                     Apache::TestConfig->thaw)->scan;
-             };
+             {
+                 local $?; # preserve the exit status
+                 eval {
+                    Apache::TestRun->new(test_config =>
+                                         Apache::TestConfig->thaw)->scan;
+                 };
+             }
          }";
 }



_____________________________________________________________________
Stas Bekman              JAm_pH     --   Just Another mod_perl Hacker
http://stason.org/       mod_perl Guide  http://perl.apache.org/guide
mailto:stas@stason.org   http://apachetoday.com http://eXtropia.com/
http://singlesheaven.com http://perl.apache.org http://perlmonth.com/



Mime
View raw message