httpd-modules-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jacob Champion <jacob.champ...@ni.com>
Subject Re: [PATCH 0/5] Fix mod_websocket segfaults under load
Date Thu, 30 Apr 2015 18:19:17 GMT
On 3/9/2015 1:43 PM, Jacob Champion wrote:
>  mod_websocket.c | 1005 +++++++++++++++++++++++++++++++++----------------------
>  1 file changed, 607 insertions(+), 398 deletions(-)

Quick bump to this thread. Have any interested parties (Alex?) been able
to give these patches a try? Any comments on coding style, architecture,
etc.?

And now for a really ambitious question: with enough cleanup and TLC,
could this module ever be considered for support as an official module?
If so, what would we need to put into it to get it there? If not, what
are the objections?

I'm particularly curious about thoughts on the threading architecture
(one thread monopolized per WebSocket), the authorship concern (IIUC,
ASF requires some trademark and/or other IP transfer, which may not be
possible if the author is gone), and just the general question of
"should Apache support WebSockets out of the box?" Does the answer to
the last question change depending on the version of Apache (2.2, 2.4, 2.6)?

Thanks!

Jacob Champion
LabVIEW R&D
National Instruments

Mime
View raw message