Mailing-List: contact modules-dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: modules-dev@httpd.apache.org
Received-SPF: pass (nike.apache.org: domain of prvs=05267bef56=micha@lenk.info
 designates 188.40.85.232 as permitted sender)
Message-ID: <55125380.7010408@lenk.info>
Date: Wed, 25 Mar 2015 07:19:44 +0100
From: Micha Lenk <micha@lenk.info>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Icedove/31.5.0
MIME-Version: 1.0
To: Yann Ylavic <ylavic.dev@gmail.com>, modules-dev@httpd.apache.org
Subject: Re: How to wait on a global lock with timeout
References: <54295C2F.80307@lenk.info>
	<CAKQ1sVMGx6F_sVCwswD9PbgcHCg5sJm1M=iFE50Qr_dh7ebAsQ@mail.gmail.com>
	<CAKQ1sVPS8Z-g0NXvZDRPhEW5bhWr3XgDp9ivUe-cA_5pw96-Ew@mail.gmail.com>
	<542AF4CB.90006@lenk.info>
 <CAKQ1sVOQmDSCaPeCg6YL8mpD=6q6mFZepR0V_E=gCOkXAoD=4Q@mail.gmail.com>
In-Reply-To: 
 <CAKQ1sVOQmDSCaPeCg6YL8mpD=6q6mFZepR0V_E=gCOkXAoD=4Q@mail.gmail.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit

Hi Yann,

Am 20.03.2015 um 02:59 schrieb Yann Ylavic:
> a few times later, commited in [1] and [2] :)

Wow, thanks for coming back to that issue.

> Can you please check if it works for you?

I only had time to review the code changes. I looked at the
implementation of apr_global_mutex_timedlock(). There I noticed that, if
APR_HAS_THREADS, you are doing 3 timed operations without checking the
remaining time. If all operations take almost the given timeout, this
can in the end result in almost 3 times the allowed value.

To mitigate that design flaw I would provide the timeout by reference
and update it by the functions using it. This has also the nice benefit
that the caller is able to retrieve the time it needed to wait.

I hope to have some time to check out the new functions in my code soon.

> I also attached the patch against 1.6.x, if that can help...
> It should also apply to 1.5.x, though it will never be backported
> there (due to API changes).

Backports are not needed. Thanks for offering.

Regards,
Micha