Mailing-List: contact modules-dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: modules-dev@httpd.apache.org
Received-SPF: pass (athena.apache.org: domain of jlewis@silverhawk.net
 designates 209.85.210.173 as permitted sender)
Sender: Joe Lewis <jlewis@silverhawk.net>
Message-ID: <4F3BDC7A.2050804@joe-lewis.com>
Date: Wed, 15 Feb 2012 09:25:30 -0700
From: Joe Lewis <joe@joe-lewis.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:10.0) Gecko/20120131 Thunderbird/10.0
MIME-Version: 1.0
To: modules-dev@httpd.apache.org
Subject: Re: NoRobot module
References: <4F3B67CA.3070401@cardiweb.com>
 <A3559566-3F8F-4811-9CA1-2D7A862CB28D@apache.org>
 <4F3B8A38.9020102@cardiweb.com>
In-Reply-To: <4F3B8A38.9020102@cardiweb.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

2 - you can make it default to "on", and then just have the option of 
turning it off per vhost.  Then there are no configuration changes for 
you, it's on, and others that find it useful (I can definitely see where 
it would be) can implement it as needed.

Aside from that, it's a simple module that looks fairly good.

Joe

On 02/15/2012 03:34 AM, Mike Baroukh wrote:
> Hi.
>
>
> 1/ thanks
>
> 2/ on/off :
> for my needs, I wanted to be sure, *really* sure, that is the module is
> enabled, the server will return this response for all vhosts.
> So I did not wan't to enable/disable it by vhost.
> Then, if it could only be on/off gloablly, adding/removing the module is
> the way to toggle it on/off ...
> On debian, it is simple : "a2(en|dis)mod norobot" ...
>
> 3/ right. I'm not sure if the last \n is mandatory, but I added it ...
>
>
> Note : I saw that the default comments, coming from the sample are wrong
> : you don't have to enable the handler per Location.
> I updated them ...
>
>
> Thanks a lot for your advices !
>
>
> Regards,
>
> Mike Baroukh
> ---
> Cardiweb  - 29 Cite d'Antin Paris IXeme
> +33 6 63 57 27 22 / +33 1 53 21 82 63
> http://www.cardiweb.com/
> ---
>
>
> Le 15/02/2012 11:07, Nick Kew a écrit :
>> On 15 Feb 2012, at 08:07, Mike Baroukh wrote:
>>
>>> Disclaimer :
>>> I'm absolutly not a C ou System developer.
>>> I'm a Java developer.
>>> And this is my first module.
>>> So maybe it could be made better ...
>> If you're asking for criticism, here goes:
>>
>> 1.  It looks fine as far as it goes.
>> 2.  But would be much more generalisable if it were configurable on/off.
>>      This would remove the issue of running order which you tackled with
>>      APR_HOOK_FIRST.
>> 3.  "Be conservative in what you send".  The last line of your
>>      robots.txt is unterminated!
>>
--
Joe Lewis
www.silverhawk.net