httpd-modules-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nick Kew <>
Subject Re: NoRobot module
Date Wed, 15 Feb 2012 10:07:33 GMT

On 15 Feb 2012, at 08:07, Mike Baroukh wrote:

> Disclaimer :
> I'm absolutly not a C ou System developer.
> I'm a Java developer.
> And this is my first module.
> So maybe it could be made better ...

If you're asking for criticism, here goes:

1.  It looks fine as far as it goes.
2.  But would be much more generalisable if it were configurable on/off.
    This would remove the issue of running order which you tackled with
3.  "Be conservative in what you send".  The last line of your
    robots.txt is unterminated!

Nick Kew

View raw message