Mailing-List: contact modules-dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: modules-dev@httpd.apache.org
Received-SPF: pass (nike.apache.org: domain of info@bnoordhuis.nl designates
 74.125.83.45 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <AANLkTinYZ-3id1_km5kvOVQqjGkU00oVCF0=8b5k67BP@mail.gmail.com>
References: <AANLkTinYZ-3id1_km5kvOVQqjGkU00oVCF0=8b5k67BP@mail.gmail.com>
Date: Mon, 14 Mar 2011 18:28:01 +0100
Message-ID: <AANLkTinUj6yuoE_pHWVMPw1sbbZoYsBh=6Y_XZdBT1FV@mail.gmail.com>
Subject: Re: ordering output filters
From: Ben Noordhuis <info@bnoordhuis.nl>
To: modules-dev@httpd.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 14, 2011 at 16:54, Joshua Marantz <jmarantz@google.com> wrote:
> Even in the absence of 'remove_comments', it would be preferable to have
> mod_pagespeed run after mod_includes so that it has an opportunity to
> optimize the included text. =A0The user can achieve this by putting this =
line
> into his config file:
>
> =A0 =A0AddOutputFilter INCLUDES;MOD_PAGESPEED_OUTPUT_FILTER html
>
> But this is not desirable for a couple of reasons. =A0We'd like to force =
the
> correct order automatically if possible.

> We also have a constraint that mod_pagespeed must run before mod_deflate.
> =A0Actually mod_pagespeed already inserts mod_deflate in the filter-chain=
 to
> run downstream of it:
>
> =A0ap_add_output_filter("DEFLATE", NULL, request, request->connection);

mod_include runs at AP_FTYPE_RESOURCE, mod_deflate at AP_FTYPE_CONTENT_SET.

If you register your filter at  AP_FTYPE_RESOURCE + 1 or
AP_FTYPE_CONTENT_SET - 1, it will run after mod_include but before
mod_deflate.