httpd-modules-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Noordhuis <i...@bnoordhuis.nl>
Subject Re: ordering output filters
Date Mon, 14 Mar 2011 17:28:01 GMT
On Mon, Mar 14, 2011 at 16:54, Joshua Marantz <jmarantz@google.com> wrote:
> Even in the absence of 'remove_comments', it would be preferable to have
> mod_pagespeed run after mod_includes so that it has an opportunity to
> optimize the included text.  The user can achieve this by putting this line
> into his config file:
>
>    AddOutputFilter INCLUDES;MOD_PAGESPEED_OUTPUT_FILTER html
>
> But this is not desirable for a couple of reasons.  We'd like to force the
> correct order automatically if possible.

> We also have a constraint that mod_pagespeed must run before mod_deflate.
>  Actually mod_pagespeed already inserts mod_deflate in the filter-chain to
> run downstream of it:
>
>  ap_add_output_filter("DEFLATE", NULL, request, request->connection);

mod_include runs at AP_FTYPE_RESOURCE, mod_deflate at AP_FTYPE_CONTENT_SET.

If you register your filter at  AP_FTYPE_RESOURCE + 1 or
AP_FTYPE_CONTENT_SET - 1, it will run after mod_include but before
mod_deflate.

Mime
View raw message