httpd-modules-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nick Kew <...@apache.org>
Subject Re: mod_sflow
Date Mon, 10 Jan 2011 23:52:49 GMT
On Fri, 7 Jan 2011 15:06:19 -0800
Neil McKee <neil.mckee@inmon.com> wrote:

> Hello all,
> 
> A new module that exports log data using the sFlow protocol is available for review:
> 
> http://mod-sflow.googlecode.com

I started to look at it, then got distracted.

Five-minute review:
 (1) It looks well-formed as a module.  If the question was
     meant to be "have I got the basics", then the answer is yes.
 (2) I don't like modules that die on error.  Use of ap_assert
     makes me uneasy.

-- 
Nick Kew

Available for work, contract or permanent.
http://www.webthing.com/~nick/cv.html

Mime
View raw message