httpd-modules-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Noordhuis <i...@bnoordhuis.nl>
Subject Re: New module for anonymous ip logging
Date Tue, 05 Oct 2010 23:11:14 GMT
Hi Franz, welcome. Replies inline:

On Wed, Oct 6, 2010 at 00:49, Franz Schwartau <franz@electromail.org> wrote:
> How should the module react to a failed initialization of seed_rand() in
> iphash_create_server_config() (line 90)? Returning NULL in
> iphash_create_server_config() doesn't seem to help. I'd like to disable
> the module somehow if the random generator could be initialized properly.

Add a 'initialized' flag to iphash_config_t and check its value in log_ip_hash.

That said, if security is an issue - which I presume it is - you are
probably better off aborting.

> No other module checks if the return value of apr_palloc() or
> apr_pcalloc() is NULL. Does it mean memory allocation via apr_palloc()
> will never fail and memory size is indefinitely? ;-)

Yep. And if memory turns out to be finite after all, the APR will tear
down the process.

Mime
View raw message