Mailing-List: contact modules-dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: modules-dev@httpd.apache.org
Received-SPF: pass (athena.apache.org: local policy)
Message-ID: <49BA816E.80803@joe-lewis.com>
Date: Fri, 13 Mar 2009 09:53:18 -0600
From: Joe Lewis <joe@joe-lewis.com>
User-Agent: Thunderbird 2.0.0.19 (X11/20090105)
MIME-Version: 1.0
To: modules-dev@httpd.apache.org
References: <6456355d0903130001q13165c19x4126c243546701d7@mail.gmail.com>
	 <49BA78D5.9090503@joe-lewis.com>
	 <6456355d0903130821w42cbf98co5b526b13f356cc4e@mail.gmail.com>
 <20170a030903130824ia40a958p842e2b053f8deaca@mail.gmail.com>
In-Reply-To: <20170a030903130824ia40a958p842e2b053f8deaca@mail.gmail.com>
Content-Type: multipart/alternative;
 boundary="------------090308030906040305080107"
Subject: Re: post_config on reload

--------------090308030906040305080107
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Sorin Manolache wrote:
> On Fri, Mar 13, 2009 at 16:21, Andrej van der Zee
> <andrejvanderzee@gmail.com> wrote:
>   
>> Hi,
>>
>> Do not do this -  a restart should be a restart, not a half of a restart.
>>     
>>>  You should be reinitializing whatever you do on a restart as well as a
>>> start.  That's the whole point.
>>>
>>> I have one phrase that should illustrate why : memory leak.
>>>
>>> For example, if your extension creates another thread or spawns another
>>> process and that other thread/process doesn't clean up on a restart and
>>> contains a memory leak, what good is restart to you? Restart has suddenly
>>> become pointless.
>>>
>>> It is good etiquette to honour the concept of a restart.
>>>
>>>       
>> Okay, point taken. My extension indeed creates a thread. How can I know that
>> a user issues a restart? In other words, where can I kill my thread?
>>     
>
> Register a function with the cleanup of the conf pool. The conf pool
> is destroyed prior to a restart/kill/reload.
>
> You have an example in the code I've sent you.
>
> S
>
>   
Perfect answer!  Unfortunately, the post_config is called twice on a 
restart, and with different memory pointers, so shared memory handles, 
mutexes, etc, those will all suddenly disappear.  You'd be forced to 
initialize your post_config again or potentially segmentation fault the 
server.  So, that is a good excuse to implement some extra code to 
handle restarting a thread anyway.

Joe

--------------090308030906040305080107--