httpd-modules-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Fister" <jasonfis...@gmail.com>
Subject Re: ap_get_client_block vs bucket brigades
Date Fri, 18 Jul 2008 01:15:39 GMT
Sorin,

On Thu, Jul 17, 2008 at 5:52 PM, Sorin Manolache <sorinm@gmail.com> wrote:

> Just a caveat. Loop like this:
>
> while ((n = ap_get_client_block()) > 0)
>  ...
>
> and not
>
> while (already_read < request->remaining) {
>   n = ap_get_client_block();
>   alread_read += n;
> }
>

Thanks for pointing it out. I am infact looping like ur first example.


>
> request->remaining may be misleading, for example if the client PUSHes
> compressed data request->remaining will indicate the size of the
> compressed data while your module will most likely read the data that
> is already decompressed by the DEFLATE filter on the input filter
> chain.
>
> >  2. Will the use of bucket brigades have a positive impact on the
> >  performance?
>
> Most likely not.
>

Thanks for your help!


Jason

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message