Mailing-List: contact modules-dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: modules-dev@httpd.apache.org
Received-SPF: pass (athena.apache.org: local policy)
Message-ID: <4713ABB3.9020606@joe-lewis.com>
Date: Mon, 15 Oct 2007 12:04:35 -0600
From: Joe Lewis <joe@joe-lewis.com>
User-Agent: Thunderbird 1.5.0.8 (X11/20060911)
MIME-Version: 1.0
To: modules-dev@httpd.apache.org
References: <393371.33560.qm@web60314.mail.yahoo.com>
In-Reply-To: <393371.33560.qm@web60314.mail.yahoo.com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Subject: Re: [Unload module]

Marin Cosmin wrote:
> Hello,
>
> I'm working on an Apache module that will log some statistics in a file.
> My problem is that I have no ideea about what should I do to unload the module.
> In ap_hook_post_config hook I initialize some structures, use open() for some files ...
> If I get an error during this phase how can I unload the module ?
>
>   

I'm not sure that unloading the module is a good idea. I'd suggest using
one of the *open_logs or *post_config hooks - and return an appropriate
error code if failure occurs. If you find that apache continues to load,
then you may want to set a flag in a configuration structure that you
can use to determine if you had success earlier. (For example, so that
you don't try to write statistics to a file that failed to open earlier).

> Where should I destroy IPCS ? 
> I used apr_pool_cleanup_register here but the behaviuor isn't the desired one.
>
> Using apr_pool_cleanup_register in ap_hook_child_init seems to work.
>   

That is where you want it - when the child starts, each child needs to
be able to clean up after itself, hence wait until the child starts to
register that one.

This is a bit more clear when comparing worker vs. prefork MPM's - each
child process has to take care of it's own in order to prevent memory
leaks, etc.

Joe
-- 
Joseph Lewis <http://sharktooth.org/>
"Divide the fire, and you will sooner put it out." - Publius Syrus