httpd-modules-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nick Kew <n...@webthing.com>
Subject Re: reading from bucket issues
Date Mon, 21 May 2007 19:46:57 GMT
On Mon, 21 May 2007 20:51:23 +0200
Mike <dykciarz@gmail.com> wrote:

> Solution 2:
> static apr_status_t my_filter(ap_filter_t *f, apr_bucket_brigade
> 		*bb) {
>         char *c;
> 	apr_size_t s;
> 	apr_brigade_pflatten(bb, &c, &s, f->r->pool);
> 	apr_brigade_cleanup(bb);
> 	ap_fputs(f->next, bb, c);

fputs puts a string, but randomly segfaults if passed a non-string.

>         apr_bucket *b = apr_bucket_eos_create(f->c->bucket_alloc);
> 	APR_BRIGADE_INSERT_TAIL(bb, b);
> 	return ap_pass_brigade(f->next, bb);
> }

This looks like a particularly useless exercise.  It incurs
a potentially-big overhead, without solving what is probably
your underlying problem of split data.

-- 
Nick Kew

Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/

Mime
View raw message