Mailing-List: contact modules-dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: modules-dev@httpd.apache.org
Received-SPF: pass (herse.apache.org: domain of djwortham@gmail.com designates
 64.233.166.182 as permitted sender)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references;
        b=WRISHemhO3EzFyK65W+7tu5daLp+IlbTUbmp9ZC9hPCfPBwI/5kFkPpgUjld+4EsAxnR95/gBpBxOh+xpeUTAiZacI+4dOkbfbJEomaS19hcj/ly3gFdeHhgkOvwajL5ypShgeab30UxZDTgsOVal9Q8LqdoQKv4xWFOj7ft61g=
Message-ID: <5280fae50611161731nf99b62bh483891b1e9167374@mail.gmail.com>
Date: Thu, 16 Nov 2006 18:31:24 -0700
From: "David Wortham" <djwortham@gmail.com>
To: modules-dev@httpd.apache.org
Subject: Re: Setting both Server and Directory Config Structs from the same
 config function
In-Reply-To: <20061117002632.7db17c44@grimnir>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_100166_15414640.1163727084329"
References: <5280fae50611161539x7c730eearb28b86372319aa27@mail.gmail.com>
	 <20061117002632.7db17c44@grimnir>

------=_Part_100166_15414640.1163727084329
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Nick,
I was almost done copy-pasting and simplifying my code when I re-read your
response.

I had previously tried an if/else in the directive handling function (as in:
if (dir->path is set) { set dir_struct; } else { set svr_struct; } ).
For some reason, I didn't think that the call had to be mutually exclusive
(only DIR or SVR, not both).

I read through the 2.0 code (thanks www.google.com/codesearch !), which has
different comments than 1.3.  In there, the path is what determines if the
directive-handling function was called via a DIR or a SVR context (and I now
realize they are mutually exclusive).  A simple test to see if the
cmd_parms->module_config is not NULL apparently is not sufficient.

I am still testing some cases, but it looks like I was able to eliminate the
case that causes a Sef Fault.

Thx Nick!
Dave


On 11/16/06, Nick Kew <nick@webthing.com> wrote:
>
> On Thu, 16 Nov 2006 16:39:26 -0700
> "David Wortham" <djwortham@gmail.com> wrote:
>
> > Hello fellow module developers!
> > I am trying to debug one of my directive-handling functions.
>
> You haven't really told us enough to make a diagnosis.
>
> However, the thing that springs to mind from the above is that
> you might need to check your command's context.  A simple first
> test for that would be to test whether there are some contexts
> where it works and others where it crashes.
>
> --
> Nick Kew
>
> Application Development with Apache - the Apache Modules Book
> http://www.apachetutor.org/
>

------=_Part_100166_15414640.1163727084329--