Return-Path: 
 <mbox-dev-return-32-apmail-httpd-mbox-dev-archive=httpd.apache.org@httpd.apache.org>
Delivered-To: apmail-httpd-mbox-dev-archive@www.apache.org
Received: (qmail 2093 invoked from network); 16 Apr 2005 08:48:39 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur.apache.org with SMTP; 16 Apr 2005 08:48:39 -0000
Received: (qmail 61595 invoked by uid 500); 16 Apr 2005 08:48:39 -0000
Delivered-To: apmail-httpd-mbox-dev-archive@httpd.apache.org
Received: (qmail 61566 invoked by uid 500); 16 Apr 2005 08:48:39 -0000
Mailing-List: contact mbox-dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
List-Post: <mailto:mbox-dev@httpd.apache.org>
List-Help: <mailto:mbox-dev-help@httpd.apache.org>
List-Unsubscribe: <mailto:mbox-dev-unsubscribe@httpd.apache.org>
List-Subscribe: <mailto:mbox-dev-subscribe@httpd.apache.org>
Delivered-To: mailing list mbox-dev@httpd.apache.org
Received: (qmail 61553 invoked by uid 99); 16 Apr 2005 08:48:39 -0000
X-ASF-Spam-Status: No, hits=0.0 required=10.0
	tests=
X-Spam-Check-By: apache.org
Received-SPF: pass (hermes.apache.org: local policy)
Received: from force-elite.com (HELO utopia.in.force-elite.com)
 (216.255.199.145)
  by apache.org (qpsmtpd/0.28) with ESMTP; Sat, 16 Apr 2005 01:48:39 -0700
X-AuthUser: chip@force-elite.com
Received: from [10.0.0.142] (10.0.0.142:53809)
	by utopia.in.force-elite.com with [XMail 1.17 (Linux/Ix86) ESMTP Server]
	id <SA8CCE> for <mbox-dev@httpd.apache.org> from <chip@force-elite.com>;
	Sat, 16 Apr 2005 01:48:36 -0700
Message-ID: <4260D163.3080902@force-elite.com>
Date: Sat, 16 Apr 2005 01:48:35 -0700
From: Paul Querna <chip@force-elite.com>
User-Agent: Mozilla Thunderbird 1.0.2 (Macintosh/20050317)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: mbox-dev@httpd.apache.org
Subject: Re: svn commit: r160602 [1/3] - in httpd/mod_mbox/trunk: ./ config/
 m4/ module-2.0/
References: <20050408203054.7502.qmail@minotaur.apache.org>
 <20050416072311.GS29417@scotch.ics.uci.edu>
In-Reply-To: <20050416072311.GS29417@scotch.ics.uci.edu>
X-Enigmail-Version: 0.89.6.0
X-Enigmail-Supports: pgp-inline, pgp-mime
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N

Justin Erenkrantz wrote:
> The store_cstring has a scoping error: it refers to 'tlen' when that's not in
> scope.  (A comment explaining what that goofy macro does would be good.)
> I'm guessing it writes out the length of the string and the string; but
> that's not real obvious from its name...
> 
> (Note: fetch_cstring has similar scoping errors.)

I believe that the scoping errors are now fixed in trunk.


> Now that I've read it through, I think it'd be far clearer if the tlen were
> grouped with the strings as in:
> 
> sstrlen(msgc->from) + sizeof(tlen) + \
> 
> I believe this makes it much clearer that the tlen size is logically grouped
> with the string fields.

I also changed this in trunk.

-Paul