httpd-mbox-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Paul Querna <c...@force-elite.com>
Subject Re: svn commit: r160602 [1/3] - in httpd/mod_mbox/trunk: ./ config/ m4/ module-2.0/
Date Sat, 16 Apr 2005 08:48:35 GMT
Justin Erenkrantz wrote:
> The store_cstring has a scoping error: it refers to 'tlen' when that's not in
> scope.  (A comment explaining what that goofy macro does would be good.)
> I'm guessing it writes out the length of the string and the string; but
> that's not real obvious from its name...
> 
> (Note: fetch_cstring has similar scoping errors.)

I believe that the scoping errors are now fixed in trunk.


> Now that I've read it through, I think it'd be far clearer if the tlen were
> grouped with the strings as in:
> 
> sstrlen(msgc->from) + sizeof(tlen) + \
> 
> I believe this makes it much clearer that the tlen size is logically grouped
> with the string fields.

I also changed this in trunk.

-Paul

Mime
View raw message