httpd-mbox-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Paul Querna <c...@force-elite.com>
Subject Re: svn commit: r161529 - httpd/mod_mbox/trunk/module-2.0/mod_mbox_file.c
Date Sat, 16 Apr 2005 07:42:55 GMT
Justin Erenkrantz wrote:
> On Sat, Apr 16, 2005 at 12:01:00AM -0000, pquerna@apache.org wrote:
> 
>>Author: pquerna
>>Date: Fri Apr 15 17:00:58 2005
>>New Revision: 161529
>>
>>URL: http://svn.apache.org/viewcvs?view=rev&rev=161529
>>Log:
>>- Add Last Modified for all pages
>>- Remove the old fetch_message function.  Replaced with the pure-offset based one.
>>- Remove the TODO for 'raw', since it was added via the pure-offset based fetch message.
>>
>>Modified:
>>    httpd/mod_mbox/trunk/module-2.0/mod_mbox_file.c
>>
>>Modified: httpd/mod_mbox/trunk/module-2.0/mod_mbox_file.c
>>URL: http://svn.apache.org/viewcvs/httpd/mod_mbox/trunk/module-2.0/mod_mbox_file.c?view=diff&r1=161528&r2=161529
>>==============================================================================
>>--- httpd/mod_mbox/trunk/module-2.0/mod_mbox_file.c (original)
>>+++ httpd/mod_mbox/trunk/module-2.0/mod_mbox_file.c Fri Apr 15 17:00:58 2005
>>@@ -623,8 +637,6 @@
>> /* This function will take the message id from the virtual namespace, and
>>  * print out the cached headers of the message and the complete body
>>  * of the message.
>>- *
>>- * FIXME: Determine if a bucket or a brigade would be useful here.
>>  */
>> static apr_status_t fetch_message(request_rec *r, apr_file_t* f)
>> {
>>@@ -639,127 +651,6 @@
>>     mbox_filter_ctx *ctx;
>>     mbox_mpartf_ctx* mctx = NULL;
>>     Message *m;
>>-
>>-    /* msgID should be the part of the URI that Apache could not resolve
>>-     * on its own.  Grab it and skip over the expected /.
>>-     */
> 
> ...snip...
> 
> Don't know if you intended this (eek, if so!), but there's dead code at the
> end of the fetch_message() function starting around line 750.  -- justin
> 

Fixed.

Mime
View raw message