httpd-docs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From André Malo ...@perlig.de>
Subject Re: svn commit: r1734349 - in /httpd/httpd/trunk/docs/manual/howto: access.html.en access.xml.fr access.xml.meta
Date Thu, 10 Mar 2016 11:41:40 GMT
* Marion & Christophe JAILLET wrote:

> Le 10/03/2016 06:28, jailletc36@apache.org a écrit :
> > Author: jailletc36
> > Date: Thu Mar 10 05:28:11 2016
> > New Revision: 1734349
> >
> > URL: http://svn.apache.org/viewvc?rev=1734349&view=rev
> > Log:
> > xforms
> >
> > Modified:
> >      httpd/httpd/trunk/docs/manual/howto/access.html.en
> >      httpd/httpd/trunk/docs/manual/howto/access.xml.fr
> >      httpd/httpd/trunk/docs/manual/howto/access.xml.meta
> >
> > Modified: httpd/httpd/trunk/docs/manual/howto/access.html.en
> > URL:
> > http://svn.apache.org/viewvc/httpd/httpd/trunk/docs/manual/howto/access.h
> >tml.en?rev=1734349&r1=1734348&r2=1734349&view=diff
> >
> > =========================================================================
> >=====
> >
> > --- httpd/httpd/trunk/docs/manual/howto/access.html.en (original)
> > +++ httpd/httpd/trunk/docs/manual/howto/access.html.en Thu Mar 10
> > 05:28:11 2016
> > @@ -71,8 +71,9 @@
> >         <p>The usage of these directives is:</p>
> >   -    <pre class="prettyprint lang-config">Require host address
> > -Require ip ip.address</pre>
> > +    <pre class="prettyprint lang-config">Require host <var>address</var>
> > +Require ip <var>ip.address</var>
> > +    </pre>
> >           <p>In the first form, <var>address</var> is a fully
qualified
>
> Hi,
>
> I tried to tweak doc to take into account
> http://httpd.apache.org/docs/2.4/howto/access.html#comment_5176
> ./build.sh    --> works fine
> ./build.sh validate-xml    --> ok
> ./build.sh validate-xhtml  --> ok
>
> However, the resulting page is not displayed correctly. The 2 lines in
> the <pre> block are displayed on the same line:
>      Require host addressRequire ip ip.address
>
> This looks like an issue with the prettyprint mechanism and I suspect it
> to remove the ending CR.

Hmm, yes, definitely. If I disable JS, it looks fine and the source is also as 
expected.

> Is <var></var> (or maybe any other formatting) allowed in the
> <highlight> blocks?

Yes, it should.

> Should prettyprint be tweaked to handle it? (I've seen that the version
> we use is not the same as the latest available at
> https://github.com/google/code-prettify)
> I quick test with the latest version, without backporting modification
> applied to the original prettify.js file, looks promising.
> So IMHO, it is either a bug now fixed in prettify.js itself or an issue
> introduced when it has been adapted for our own use.
>
> I leave my change in trunk
> http://httpd.apache.org/docs/trunk/en/howto/access.html) but revert it
> for now in 2.4.x.

I'll give it a closer look later.

Cheers,
nd
-- 
"Das Verhalten von Gates hatte mir bewiesen, dass ich auf ihn und seine
beiden Gefährten nicht zu zählen brauchte" -- Karl May, "Winnetou III"

Im Westen was neues: <http://pub.perlig.de/books.html#apache2>

---------------------------------------------------------------------
To unsubscribe, e-mail: docs-unsubscribe@httpd.apache.org
For additional commands, e-mail: docs-help@httpd.apache.org


Mime
View raw message