Return-Path: X-Original-To: apmail-httpd-docs-archive@www.apache.org Delivered-To: apmail-httpd-docs-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BE57698F7 for ; Tue, 24 Apr 2012 18:06:05 +0000 (UTC) Received: (qmail 59333 invoked by uid 500); 24 Apr 2012 18:06:05 -0000 Delivered-To: apmail-httpd-docs-archive@httpd.apache.org Received: (qmail 59279 invoked by uid 500); 24 Apr 2012 18:06:05 -0000 Mailing-List: contact docs-help@httpd.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: docs@httpd.apache.org List-Id: Delivered-To: mailing list docs@httpd.apache.org Received: (qmail 59271 invoked by uid 99); 24 Apr 2012 18:06:05 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Apr 2012 18:06:05 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: local policy) Received: from [217.160.171.50] (HELO jupiter.hal-nine-zero-zero-zero.net) (217.160.171.50) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 24 Apr 2012 18:05:56 +0000 Received: (qmail 18208 invoked from network); 24 Apr 2012 18:05:36 -0000 Received: from unknown (HELO localhost) (217.160.171.50) by jupiter.hal-nine-zero-zero-zero.net with SMTP; 24 Apr 2012 18:05:36 -0000 From: =?iso-8859-1?q?Andr=E9_Malo?= Organization: TIMTOWTDI To: docs@httpd.apache.org Subject: Re: Syntax Highlighting Date: Tue, 24 Apr 2012 20:06:24 +0200 User-Agent: KMail/1.9.10 References: <4819cef1-ffe0-42a5-87a6-b11ebe41d3b6@iris> <4F96B73A.5080705@cord.dk> <4F96D193.2020404@cord.dk> In-Reply-To: <4F96D193.2020404@cord.dk> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-6" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <201204242006.24835@news.perlig.de> * Daniel Gruno wrote: > After hearing some concerns expressed over whether we could include a > GPL3 licensed script in our documentation, I have looked for alternate > solutions, and found a syntax highlighter that it Apache 2.0 licensed. Oh, well. > This requires a small change to the common.xsl file (revert the previous > changed and apply this new patch instead, if you want to try it out), > and two additional files, which I have placed in the trunk (a js and a > css file). The patch looks ok, just minor comments from me: =2D Please avoid unrelated whitespace changes + =A0 =A0if (prettyPrint) { this won't work in case of missing external JS. You need to check for=20 window.prettyPrint or typeof(prettyPrint)!=3D=3Dundefined. nd =2D-=20 Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook! Ook? Ook. Ook? Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook? Ook. Ook! Ook! Ook? Ook! Ook. Ook? Ook. Ook. Ook. Ook. Ook. Ook. Ook! Ook. Ook! Ook! Ook! Ook! Ook! Ook. --------------------------------------------------------------------- To unsubscribe, e-mail: docs-unsubscribe@httpd.apache.org For additional commands, e-mail: docs-help@httpd.apache.org