httpd-docs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From André Malo ...@perlig.de>
Subject Re: Syntax Highlighting
Date Tue, 24 Apr 2012 18:06:24 GMT
* Daniel Gruno wrote:

> After hearing some concerns expressed over whether we could include a
> GPL3 licensed script in our documentation, I have looked for alternate
> solutions, and found a syntax highlighter that it Apache 2.0 licensed.

Oh, well.

> This requires a small change to the common.xsl file (revert the previous
> changed and apply this new patch instead, if you want to try it out),
> and two additional files, which I have placed in the trunk (a js and a
> css file).

The patch looks ok, just minor comments from me:

- Please avoid unrelated whitespace changes

+    if (prettyPrint) {

this won't work in case of missing external JS. You need to check for 
window.prettyPrint or typeof(prettyPrint)!==undefined.

nd
-- 
Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook.
Ook! Ook? Ook. Ook? Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook.
Ook. Ook. Ook. Ook. Ook? Ook. Ook! Ook! Ook? Ook! Ook. Ook? Ook. Ook.
Ook. Ook. Ook. Ook. Ook! Ook. Ook! Ook! Ook! Ook!           Ook! Ook.

---------------------------------------------------------------------
To unsubscribe, e-mail: docs-unsubscribe@httpd.apache.org
For additional commands, e-mail: docs-help@httpd.apache.org


Mime
View raw message