httpd-docs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tony Stevenson <t...@pc-tony.com>
Subject Re: Patch for trunk/howto/cgi.xml
Date Sat, 09 Jun 2007 00:53:53 GMT


Vincent Bray wrote:
> On 09/06/07, Tony Stevenson <tony@pc-tony.com> wrote:
>> Index: cgi.xml
>> ===================================================================
>> --- cgi.xml     (revision 545660)
>> +++ cgi.xml     (working copy)
>> @@ -57,6 +57,15 @@
>>      need to have Apache configured to permit CGI execution. There
>>      are several ways to do this.</p>
>>
>> +    <p>If Apache has been build with shared module support you need to
>> +    ensure that the module is loaded, in your <code>httpd.conf</code>
>> +    you need to make sure the <code>LoadModule</code> directive has
not
>> +    been commented out.  A correctly configured directive may look 
>> like this:</p>
>
> s/build/built/
>
> Your phrasing seems a little awkward but I'm not sure which page this
> is for as your diff doesn't specify the path. Could I suggest that you
> send patches from the base of the httpd directory, and specify which
> version the patch is for? I believe it's generally best to send
> patches for trunk by default.

The patch is for trunk.  Hence the subject line  :)
Good point on the path to the file though which is why I include it in 
the email.  As getting Tortoise to add the path is not pretty.
You basically have to tell it to generate patches for the entire tree, 
then de-select the ones you don't want to patch, in this case all files, 
except  cgi.xml, and that takes a *very long* time

Updated patch attached.




Mime
View raw message