httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christophe JAILLET <christophe.jail...@wanadoo.fr>
Subject Re: svn commit: r1857857 - /httpd/httpd/trunk/modules/http/http_core.c
Date Wed, 24 Apr 2019 20:29:14 GMT
Le 22/04/2019 à 12:02, Yann Ylavic a écrit :
> Hi Christophe,
>
> On Sat, Apr 20, 2019 at 9:01 AM <jailletc36@apache.org> wrote:
>>                   ap_process_async_request(r);
>> -                /* After the call to ap_process_request, the
>> -                 * request pool may have been deleted.  We set
>> -                 * r=NULL here to ensure that any dereference
>> -                 * of r that might be added later in this function
>> -                 * will result in a segfault immediately instead
>> -                 * of nondeterministic failures later.
>> -                 */
>> -                r = NULL;
> r = NULL is indeed useless, but the comment not that much IMO.
> Adding something like ap_log_rerror() here later would be bad (we've
> been bitten by EOR several times already), so I'd prefer a comment
> still to not touch *r from here, for future proof...
>
>
> Regards,
> Yann.
>
Reverted.

The comment is about 'ap_process_request()'. Should it be updated to 
'ap_process_async_request()' ?


CJ


Mime
View raw message