httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yann Ylavic <ylavic....@gmail.com>
Subject Re: svn commit: r1857857 - /httpd/httpd/trunk/modules/http/http_core.c
Date Mon, 22 Apr 2019 10:02:55 GMT
Hi Christophe,

On Sat, Apr 20, 2019 at 9:01 AM <jailletc36@apache.org> wrote:
>
>                  ap_process_async_request(r);
> -                /* After the call to ap_process_request, the
> -                 * request pool may have been deleted.  We set
> -                 * r=NULL here to ensure that any dereference
> -                 * of r that might be added later in this function
> -                 * will result in a segfault immediately instead
> -                 * of nondeterministic failures later.
> -                 */
> -                r = NULL;

r = NULL is indeed useless, but the comment not that much IMO.
Adding something like ap_log_rerror() here later would be bad (we've
been bitten by EOR several times already), so I'd prefer a comment
still to not touch *r from here, for future proof...


Regards,
Yann.

Mime
View raw message