httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rainer Jung <>
Subject Re: [VOTE] Release httpd-2.4.32
Date Wed, 14 Mar 2018 11:10:20 GMT
Am 10.03.2018 um 03:49 schrieb Daniel Ruggeri:
> Hi, all;
>     Please find below the proposed release tarball and signatures:
> I would like to call a VOTE over the next few days to release this 
> candidate tarball as 2.4.32:
> [X] +1: It's not just good, it's good enough!
> [ ] +0: Let's have a talk.
> [ ] -1: There's trouble in paradise. Here's what's wrong.
> The computed digests of the tarball up for vote are:
> md5: cddf45e036657ea209145169a554bbff *httpd-2.4.32.tar.gz
> sha1: fc1f26a4d302639932332ea12b40de7503f8aab0 *httpd-2.4.32.tar.gz
> sha256: 11cd0c43135ffe89706d0558abc0d19cb4a1f203e11ada52f2e1c3f790959300 
> *httpd-2.4.32.tar.gz

+1 to release and thank for RM!

Detailed report:

- Sigs and hashes OK
- contents of tarballs identical
- contents of tag and tarballs identical
   except for expected deltas
- deps convenience tarball contains latest APR/APU 1.6.3/1.6.1

Built on

- Solaris 10 Sparc as 32 Bit Binaries
- SLES 11+12 (64 Bits)
- RHEL 6+7 (64 Bits)

For all platforms built

- with default (shared), static and explicit shared modules
- with module sets reallyall, all, most, few, none and default
- using --enable-load-all-modules
- against "included" APR/APU from deps tarball,
   plus external APR/APU 1.6.3/1.6.1 and 1.5.2/1.5.4

- using external libraries
   - expat 2.2.5
   - pcre 8.41
   - openssl 1.0.2n plus patches
   - lua 5.3.4 (compiled with LUA_COMPAT_MODULE)
   - distcache 1.5.1
   - libxml2 2.9.8
   - libnghttp2 1.31.0
   - brotli 1.0.3
   - curl 7.58.0
   - jansson 2.11

- Tool chain:
     - platform gcc except on Solaris
       (gcc 7.3.0 Solaris 10, only older APR/APU 1.5.x compiled with 
older gcc 4.9.2)
     - CFLAGS: -O2 -g -Wall -fno-strict-aliasing
       - on Solaris additionally -mpcu=v9, -D_XOPEN_SOURCE,
         and -D_XPG6

All 280 builds succeeded.

- compiler warnings:

   - modules/core/mod_watchdog.c:436: warning: 'rv' may be used
     uninitialized in this function
   -> only on SLES 11, warning is correct but not critical (debug log);
      not a regression

   on RHEL 6 and SLES 11 due to older GCC versions:

   - modules/md/md_json.c:31: warning: expected [error|warning|ignored] 
after '#pragma GCC diagnostic'

   - modules/md/md_json.c:45: warning: expected [error|warning|ignored] 
after '#pragma GCC diagnostic'

   due to strange jansson dependency library header files:

include/jansson.h:134:6: warning: 'json_decrefp' defined but not used 
include/jansson.h:180:41: warning: 'json_error_code' defined but not 
used [-Wunused-function]
include/jansson.h:228:5: warning: 'json_object_set_nocheck' defined but 
not used [-Wunused-function]
include/jansson.h:234:5: warning: 'json_object_iter_set' defined but not 
used [-Wunused-function]
include/jansson.h:249:5: warning: 'json_array_set' defined but not used 
include/jansson.h:261:5: warning: 'json_array_insert' defined but not 
used [-Wunused-function]

   and only on Solaris (gcc 7.3.0)

   - modules/ldap/util_ldap_cache_mgr.c:728:32: warning: format '%ld' 
expects argument of type 'long int', but argument 6 has type 'long long 
int' [-Wformat=]

   - modules/ldap/util_ldap_cache.c:111:20: warning: format '%ld' 
expects argument of type 'long int', but argument 8 has type 'long long 
int' [-Wformat=]

   - srclib/apr-util/xlate/xlate.c:120:38: warning: passing argument 2 of
     'iconv' from incompatible pointer type

   - srclib/apr-util/xlate/xlate.c:343:42: warning: passing argument 2 of
     'iconv' from incompatible pointer type

Tested for

- Solaris 10, SLES 11+12, RHEL 6+7
- MPMs prefork, worker, event
   - prefork skipped on Solaris due to the accept lock problem that
     leads to timeouts and thus excessive testing times in the proxy
- default, shared and static module builds
- log levels info, debug and trace8
- module sets reallyall, all, most, few, none and default
   - for "reallyall" 128 modules plus MPMs, less for other module sets
- in total 2352 combinations

The following test failures were seen:

a t/ab/base.t tests 1, 3 and 5 fail always on Linux
   - # Failed test 1 in t/ab/base.t at line 29
   - # Failed test 3 in t/ab/base.t at line 35
   - # Failed test 5 in t/ab/base.t at line 39
   This might be due to differences in my Perl test environment, Solaris
   is using a cutom build 5.22.0, Linux platforms use their platform
   perl but with custom build test modules.
   The tests are new, so my guess is, this is not a regression but
   something we need to fix in the test.

b Testing fails for module set "none" due to "User" directive
   in default config:
   AH00526: Syntax error on line 30 of .../t/conf/httpd.conf:
   Invalid command 'User', perhaps misspelled or defined by a module not
   included in the server configuration
   Not a regression

c Test 59 of t/modules/include.t only and always on
   Not a regression
   Old analysis was:
   This is due to a bug in the test, which uses strftime()
   with a "%s" pattern that is not supported on Solaris.
   Until recently the server and the test client both returned
   verbatim "%s" and the test succeeded. After updating some
   Perl modules for the http2 tests, the perl client even
   on Solaris now supports "%s" in strftime and the test starts
   to fail. It seems we have to fix the test.

d Various tests in t/apache/expr_string.t
   Not a regression.
   Test numbers : 6, 11, 14, 17, 20, 23, 26, 29
   Happens for 36 out of about 2300 runs (33 times on RHEL6,
   2 times on SLES11, once on Solaris).
   The failure is always on line 87, where the error_log contents
   are checked.

e Test 5 in t/modules/dav.t:
   5 times, various platforms.
   Creation, modified and now times not in the correct order.
   This seems to be a system issue, all tests done on NFS,
   many tested on virtualized guests.
   Not a regression.

f TODO passed for:
   t/apache/server_name_port.t tests 32, 35, 56, 59, 80, 83
   t/modules/rewrite.t test 26

g I expect prefork on Solaris still to observe timeouts during
   proxy tests like reported for previous versions, but didn't test
   it this time. Old info for reference:
   Not observed for static builds. Only builds based on APR/APU 1.6.x
   seem to have the problem. First observed when testing 2.4.26.
   It seems processes die due to Solaris mutex deadlock detection
   for the accept mutex (false positive). Such processes get not
   replaced until we end up with only one prefork child, which of
   course can't serve proxy requests.

So no show stoppers seen here.



View raw message