httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@gmail.com>
Subject Re: svn commit: r1822849 - /httpd/httpd/trunk/modules/proxy/proxy_util.c
Date Thu, 01 Feb 2018 08:00:49 GMT
On Thu, Feb 1, 2018 at 1:34 AM, <rpluem@apache.org> wrote:

> Author: rpluem
> Date: Thu Feb  1 07:34:02 2018
> New Revision: 1822849
>
> URL: http://svn.apache.org/viewvc?rev=1822849&view=rev
> Log:
> * When mod_http2 is loaded more then ThreadsPerChild backend connections
> can
>   be useful as mod_http2 has an additional thread pool on top of
>   ThreadsPerChild.
>   But leave the default with ThreadsPerChild.
>
> Modified:
>     httpd/httpd/trunk/modules/proxy/proxy_util.c
>
> Modified: httpd/httpd/trunk/modules/proxy/proxy_util.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/
> proxy/proxy_util.c?rev=1822849&r1=1822848&r2=1822849&view=diff
> ============================================================
> ==================
> --- httpd/httpd/trunk/modules/proxy/proxy_util.c (original)
> +++ httpd/httpd/trunk/modules/proxy/proxy_util.c Thu Feb  1 07:34:02 2018
> @@ -1841,8 +1841,7 @@ PROXY_DECLARE(apr_status_t) ap_proxy_ini
>
>          ap_mpm_query(AP_MPMQ_MAX_THREADS, &mpm_threads);
>          if (mpm_threads > 1) {
> -            /* Set hard max to no more then mpm_threads */
> -            if (worker->s->hmax == 0 || worker->s->hmax > mpm_threads)
{
> +            if (worker->s->hmax == 0) {
>                  worker->s->hmax = mpm_threads;
>

Would be nice to leave *some* kind of explanatory comment in there. Without
that comment, the only explanation is "way over there" in commit log
messages.

Cheers,
-g

Mime
View raw message